From d8bfc6ce39396f61a71557170e2978016dd04a5b Mon Sep 17 00:00:00 2001
From: Ralph Soika <ralph.soika@imixs.com>
Date: Tue, 13 Jun 2023 11:01:33 +0200
Subject: [PATCH] fix null pointer exception

---
 .../alexanderlogistics/OPListController.java  | 26 ++++++++++++-------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/office-alexander-logistics-app/src/main/java/com/alexanderlogistics/OPListController.java b/office-alexander-logistics-app/src/main/java/com/alexanderlogistics/OPListController.java
index 5a73997..fa889df 100644
--- a/office-alexander-logistics-app/src/main/java/com/alexanderlogistics/OPListController.java
+++ b/office-alexander-logistics-app/src/main/java/com/alexanderlogistics/OPListController.java
@@ -189,21 +189,27 @@ public class OPListController implements Serializable {
 
         // finally we set the 'selection' item depending on the $workitemList
         // and the payment amount form the 'payment.details'
-        List<String> selection = workflowController.getWorkitem().getItemValue("$workitemref");
-        List<ItemCollection> paymentList = zahlungseingangService.loadPaymentDetails(workflowController.getWorkitem());
-        for (ItemCollection invoice : invoiceList) {
-            if (selection.contains(invoice.getUniqueID())) {
-                invoice.setItemValue("selected", true);
-                // set amount
-                for (ItemCollection payment : paymentList) {
-                    if (invoice.getUniqueID().equals(payment.getUniqueID())) {
-                        invoice.setItemValue("payment.amount", payment.getItemValue("payment.amount"));
-                        break;
+        if (invoiceList!=null)  {
+            List<String> selection = workflowController.getWorkitem().getItemValue("$workitemref");
+            List<ItemCollection> paymentList = zahlungseingangService.loadPaymentDetails(workflowController.getWorkitem());
+            for (ItemCollection invoice : invoiceList) {
+                if (selection.contains(invoice.getUniqueID())) {
+                    invoice.setItemValue("selected", true);
+                    // set amount
+                    for (ItemCollection payment : paymentList) {
+                        if (invoice.getUniqueID().equals(payment.getUniqueID())) {
+                            invoice.setItemValue("payment.amount", payment.getItemValue("payment.amount"));
+                            break;
+                        }
                     }
                 }
             }
+        } else {
+            // empty list 
+            invoiceList = new ArrayList<ItemCollection>();
         }
 
+
         return invoiceList;
     }