fixed KSeFAdapter - compute pos numbers manually

office-alexander-logistics-app/src/main/java/com/alexanderlogistics/einvoice/KSeFAdapter.java

@@ -212,12 +212,18 @@ public class KSeFAdapter implements SignalAdapter {
                     workitem.getItemValueString("invoice.currency"));
 
             // Update Invoice Items
+            // Here we compute the pos number independent if the _childitems hold a posnum.
+            // This is because a new imported cargosoft invoice does not provide numPos
+            // items in the child list. So it is important to generate the pos numbers here
+            // one by one
             List<ItemCollection> invoiceItems = InvoiceUtil.explodeChildList(workitem, "_childitems");
             double lineTotalAmount = 0.00;
+            int pos = 1;
             for (ItemCollection invoiceItem : invoiceItems) {
-                TradeLineItem tradeLineItem = buildTradeLineItem(invoiceItem);
+                TradeLineItem tradeLineItem = buildTradeLineItem(invoiceItem, pos);
                 model.setTradeLineItem(tradeLineItem);
                 lineTotalAmount = lineTotalAmount + tradeLineItem.getTotal();
+                pos++;
             }
 
             // Summenbildung
@@ -340,12 +346,16 @@ public class KSeFAdapter implements SignalAdapter {
      * Parses the data list of an invoice line and returns a TradeLineItem object.
      * The order of the list items must be exactly!
      */
-    private TradeLineItem buildTradeLineItem(ItemCollection orderItem) {
+    private TradeLineItem buildTradeLineItem(ItemCollection orderItem, int pos) {
         if (orderItem == null) {
             return null;
         }
 
-        TradeLineItem tradeLineItem = new TradeLineItem(orderItem.getItemValueString("numpos"));
+        // TradeLineItem tradeLineItem = new
+        // TradeLineItem(orderItem.getItemValueString("numpos"));
+        // We do not trust the item 'numPos' here because it can be empty for new
+        // invoices!
+        TradeLineItem tradeLineItem = new TradeLineItem(pos + "");
 
         tradeLineItem.setName(orderItem.getItemValueString("datev.text"));
         tradeLineItem.setQuantity(1);